On Wed, Jul 19, 2017 at 12:34:18AM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@xxxxxxx> > > When devm_clk_get() fails the real error code should be propagated, > instead of always returning -EPROBE_DEFER. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx> Hi Fabio, I don't think -EPROBE_DEFER is returned by clk_get() if the clock can't be found. The clock providers often are e.g. ISP drivers that may well be loaded after the sensor driver. In that case this change would prevent successful initialisation of the drivers. > --- > drivers/media/i2c/ov7670.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c > index 7270c68..552a881 100644 > --- a/drivers/media/i2c/ov7670.c > +++ b/drivers/media/i2c/ov7670.c > @@ -1614,7 +1614,7 @@ static int ov7670_probe(struct i2c_client *client, > > info->clk = devm_clk_get(&client->dev, "xclk"); > if (IS_ERR(info->clk)) > - return -EPROBE_DEFER; > + return PTR_ERR(info->clk); > clk_prepare_enable(info->clk); > > ret = ov7670_init_gpio(client, info); > -- > 2.7.4 > -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
