On Tue, 10 Nov 2009, Laurent Pinchart wrote: > Hi Guennadi, > > On Friday 30 October 2009 15:01:06 Guennadi Liakhovetski wrote: > > Introduce new v4l2-subdev sensor operations, move .enum_framesizes() and > > .enum_frameintervals() methods to it, > > I understand that we need sensor-specific operations, but I'm not sure if > those two are really unneeded for "non-sensor" video. I suspect that wasn't my idea:-) Ok, found: http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/8990/focus=9078 > Speaking about enum_framesizes() and enum_frameintervals(), wouldn't it be > better to provide a static array of data instead of a callback function ? That > should be dealt with in another patch set of course. TBH, I don't understand why these methods are needed at all. Why the existing {S,G,TRY}_FMT are not enough. So, obviously, this isn't a question to me either. > > add a new .g_skip_top_lines() method and switch soc-camera to use it instead > > of .y_skip_top soc_camera_device member, which can now be removed. > > BTW, the lines of "garbage" you get at the beginning of the image is actually > probably meta-data (such as exposure settings). Maybe the g_skip_top_lines() > operation could be renamed to something meta-data related. Applications could > also be interested in getting the data. Aha, that's interesting, thanks! Yes, we could easily rename it to .g_metadata_lines() or something like that. Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
