Hans Verkuil <hverkuil@xxxxxxxxx> writes: > Hi Eric, > > On 16/07/17 12:48, Hans Verkuil wrote: >> From: Hans Verkuil <hans.verkuil@xxxxxxxxx> >> >> This patch adds support to VC4 for CEC. >> >> Thanks to Eric Anholt for providing me with the CEC register information. >> >> To prevent the firmware from eating the CEC interrupts you need to add this to >> your config.txt: >> >> mask_gpu_interrupt1=0x100 > > I put this text in the commit log, but I think it should also go into the source. > Do you agree? > > Should I also mention this in the kernel log via a 'dev_info'? It's not an obvious > config option, after all. > > Or do you have other ideas regarding this? The firmware should have been masking this interrupt for ages (~2 years?), as long as it sees the kernel's DT instead of the downstream one. I've dropped the commit message comment about that, added a bit of explanation of having a separate Kconfig, and pushed. Huge thanks for your work on this!
Attachment:
signature.asc
Description: PGP signature
