Re: [PATCH] [media] ddbridge: constify i2c_algorithm structure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Mon, 10 Jul 2017 17:12:27 +0200
schrieb Daniel Scheller <d.scheller.oss@xxxxxxxxx>:

> From: Daniel Scheller <d.scheller@xxxxxxx>
> 
> Original patch and issue identified by Gustavo A. R. Silva
> <garsilva@xxxxxxxxxxxxxx> via [1] using Coccinelle. While at it, even
> mark the struct static again since it isn't referenced anywhere else.
> 
> [1] http://www.spinics.net/lists/linux-media/msg118221.html
> 
> Cc: Gustavo A. R. Silva <garsilva@xxxxxxxxxxxxxx>
> Signed-off-by: Daniel Scheller <d.scheller@xxxxxxx>
> ---
>  drivers/media/pci/ddbridge/ddbridge-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c
> b/drivers/media/pci/ddbridge/ddbridge-i2c.c index
> 22b2543da4ca..3d0aefe05cec 100644 ---
> a/drivers/media/pci/ddbridge/ddbridge-i2c.c +++
> b/drivers/media/pci/ddbridge/ddbridge-i2c.c @@ -212,7 +212,7 @@
> static u32 ddb_i2c_functionality(struct i2c_adapter *adap) return
> I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; }
>  
> -struct i2c_algorithm ddb_i2c_algo = {
> +static const struct i2c_algorithm ddb_i2c_algo = {
>  	.master_xfer   = ddb_i2c_master_xfer,
>  	.functionality = ddb_i2c_functionality,
>  };

This one can be marked "Obsolete" in patchwork. Original ddbridge
patches have since been rebased (will re-send soonish), with this change
included.

Best regards,
Daniel Scheller
-- 
https://github.com/herrnst



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux