On 22/07/17 13:16, Sylwester Nawrocki wrote:
> On 07/21/2017 12:57 PM, Hans Verkuil wrote:
>> From: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>>
>> Since the driver_version field in struct media_device is no longer
>> used, just remove it.
>>
>> Signed-off-by: Hans Verkuil <hans.verkuil@xxxxxxxxx>
>> ---
>> drivers/media/media-device.c | 3 ---
>> include/media/media-device.h | 2 --
>> 2 files changed, 5 deletions(-)
>
>> diff --git a/include/media/media-device.h b/include/media/media-device.h
>> index 6896266031b9..7d268802cc2e 100644
>> --- a/include/media/media-device.h
>> +++ b/include/media/media-device.h
>> @@ -68,7 +68,6 @@ struct media_device_ops {
>> * @serial: Device serial number (optional)
>> * @bus_info: Unique and stable device location identifier
>> * @hw_revision: Hardware device revision
>> - * @driver_version: Device driver version
>> * @topology_version: Monotonic counter for storing the version of the graph
>> * topology. Should be incremented each time the topology changes.
>> * @id: Unique ID used on the last registered graph object
>> @@ -134,7 +133,6 @@ struct media_device {
>> char serial[40];
>> char bus_info[32];
>> u32 hw_revision;
>> - u32 driver_version;
>
> It seems we still have such paragraph in include/media/media-device.h:
>
> * - &media_entity.driver_version is formatted with the KERNEL_VERSION()
> * macro. The version minor must be incremented when new features are added
> * to the userspace API without breaking binary compatibility. The version
> * major must be incremented when binary compatibility is broken.
>
> Shouldn't this also be removed?
Good catch! Yes, that should be removed as well.
Regards,
Hans
