On 07/21/2017 10:01 AM, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In a previous commit, we added FE_NONE as an unknown fe_status.
> Initialize variable s to FE_NONE instead of the more opaque value 0.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
The change looks good to me.
Reviewed-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
I think this patch should be part of a patch series that includes
the uAPI Documentation change, uAPI change, and the following
patch:
[PATCH][V2] dvb_frontend: ensure that inital front end status initialized
based on Mauro's review comments. Anyway, I will leave it to Mauro to
decide how he wants the patches split and if he is okay with uAPI change.
thanks,
-- Shuah
> ---
> drivers/media/dvb-core/dvb_frontend.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb-core/dvb_frontend.c
> index 18cc3bbc699c..114994ca0929 100644
> --- a/drivers/media/dvb-core/dvb_frontend.c
> +++ b/drivers/media/dvb-core/dvb_frontend.c
> @@ -460,7 +460,7 @@ static int dvb_frontend_swzigzag_autotune(struct dvb_frontend *fe, int check_wra
>
> static void dvb_frontend_swzigzag(struct dvb_frontend *fe)
> {
> - enum fe_status s = 0;
> + enum fe_status s = FE_NONE;
> int retval = 0;
> struct dvb_frontend_private *fepriv = fe->frontend_priv;
> struct dtv_frontend_properties *c = &fe->dtv_property_cache, tmp;
>
