From: Hans Verkuil <hans.verkuil@xxxxxxxxx> Just a little thing that always annoyed me: the driver_version should be set in media_device_init, not in the drivers themselves. The version number never, ever gets updated in drivers. We saw that in the other media subsystems and now the core always sets it, not drivers. This works much better, and also works well when backporting the media code to an older kernel using the media_build system, where the driver version is set to the kernel version you are backporting from. Note: the media_device driver_version does not appear to be set in the omap3isp driver, so I assume it returns 0 as the version? Is that indeed the case or did I miss something? Regards, Hans Hans Verkuil (4): media-device: set driver_version in media_device_init s3c-camif: don't set driver_version anymore uvc: don't set driver_version anymore atomisp2: don't set driver_version anymore drivers/media/media-device.c | 4 +--- drivers/media/platform/s3c-camif/camif-core.c | 1 - drivers/media/usb/uvc/uvc_driver.c | 1 - drivers/staging/media/atomisp/pci/atomisp2/atomisp_v4l2.c | 5 +---- 4 files changed, 2 insertions(+), 9 deletions(-) -- 2.13.2
