Re: [PATCH v3 01/10] [media] dvb-frontends: add ST STV0910 DVB-S/S2 demodulator frontend driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Am Thu, 20 Jul 2017 14:21:24 -0300
schrieb Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxxxxx>:

> The right coding style for multi-line comments is:
> 
> 	/*
> 	 * foo
> 	 * bar
> 	 */
> 
> I ended by merging this series,[...]

Thanks alot!

> but please send a fixup patch
> when you have some time.
> 
> Btw, specially for new drivers, it could worth running checkpatch in
> scritct mode:

Well. Honestly, I wasn't fully aware of the "strict" option (at least
until Jasmin was told about it, but then the patches were there for
some time already). Since I have two (maybe three) minors for the
stv0910 driver in my GIT which I'd like to also submit, I will check
and fix up things in addition.

> Several of those warnings can be automatically fixed with:
> 
> ./scripts/checkpatch.pl -f $(git diff 435945e08551|diffstat -p1
> -l|grep -v MAINT) --strict --fix-inplace
> 
> But you need to review if the results are ok.

Thanks for the hints!

Best regards,
Daniel Scheller
-- 
https://github.com/herrnst



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux