On Wed, Jul 19, 2017 at 02:02:46PM +0200, Pavel Machek wrote: > On Tue 2017-07-18 21:41:07, Sakari Ailus wrote: > > The V4L2 flash interface allows controlling multiple LEDs through a single > > sub-devices if, and only if, these LEDs are of different types. This > > approach scales badly for flash controllers that drive multiple flash LEDs > > or for LED specific associations. Essentially, the original assumption of a > > LED driver chip that drives a single flash LED and an indicator LED is no > > longer valid. > > > > Address the matter by registering one sub-device per LED. > > > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> > > Acked-by: Pavel Machek <pavel@xxxxxx> Thanks! > > Does anything need to be done with drivers/media/i2c/adp1653.c ? Well, it does expose the two LEDs through the same sub-device. I don't think that'd really be an issue. The drivers/media/i2c/as3645a.c does the same, I think it's fine to keep that. Effectively only new drivers will have the new behaviour (apart from the greybus staging driver). -- Regards, Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
