Hi Yong,
On Wed, Jul 19, 2017 at 09:22:49AM +0800, Yong wrote:
> On Tue, 18 Jul 2017 14:55:30 +0300
> Baruch Siach <baruch@xxxxxxxxxx> wrote:
> > I am trying to get this driver working on the Olimex A33 OLinuXino. I
> > didn't get it working yet, but I had some progress. See the comment below
> > on one issue I encountered.
> >
> > On Tue, Jun 27, 2017 at 07:07:34PM +0800, Yong Deng wrote:
> > > Add binding documentation for Allwinner CSI.
> > >
> > > Signed-off-by: Yong Deng <yong.deng@xxxxxxxxxxxx>
> > > ---
[...]
> > > +Example:
> > > +
> > > + csi1: csi@01cb4000 {
> > > + compatible = "allwinner,sun8i-v3s-csi";
> > > + reg = <0x01cb4000 0x1000>;
> >
> > You use platform_get_resource_byname() to get this IO resource. This requires
> > adding mandatory
> >
> > reg-names = "csi";
> >
> > But is it actually needed? Wouldn't a simple platform_get_resource() be
> > enough?
>
> You are right.
> This will be fixed in the next version.
> I am waiting for more comments for the sunxi-csi.h. It's pleasure if
> you have any suggestions about it.
You mean sunxi_csi.h, right?
Why do you need the sunxi_csi_ops indirection? Do you expect to add
alternative implementations of these ops at some point?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@xxxxxxxxxx - tel: +972.2.679.5364, http://www.tkos.co.il -
