On Tue, 2017-07-18 at 12:03 +0200, Hans Verkuil wrote: > On 17/07/17 12:55, Philipp Zabel wrote: > > Now that the multiplexer framework is merged, drop the temporary > > mmio-mux implementation from the video-mux driver and convert it to use > > the multiplexer API. > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > > --- > > drivers/media/platform/video-mux.c | 53 +++++--------------------------------- > > 1 file changed, 7 insertions(+), 46 deletions(-) > > > > diff --git a/drivers/media/platform/video-mux.c b/drivers/media/platform/video-mux.c > > index 665744716f73b..ee89ad76bee23 100644 > > --- a/drivers/media/platform/video-mux.c > > +++ b/drivers/media/platform/video-mux.c > > @@ -17,8 +17,7 @@ > > #include <linux/err.h> > > #include <linux/module.h> > > #include <linux/mutex.h> > > -#include <linux/regmap.h> > > -#include <linux/mfd/syscon.h> > > +#include <linux/mux/consumer.h> > > Shouldn't Kconfig be modified as well to select the multiplexer? Am I missing something? The mux framework has stubs, so this compiles fine without MULTIPLEXER enabled. On the other hand this driver is pretty useless without the multiplexer framework, and the i2c and iio muxes select it as well. I'll change it and send a v2. regards Philipp
