Hi Pavel,
On Tue, Jul 18, 2017 at 12:03:52PM +0200, Pavel Machek wrote:
> Hi!
>
> > > diff --git a/drivers/media/platform/omap3isp/ispccp2.c
> > > b/drivers/media/platform/omap3isp/ispccp2.c index
> > > 4f8fd0c00748..47210b102bcb 100644
> > > --- a/drivers/media/platform/omap3isp/ispccp2.c
> > > +++ b/drivers/media/platform/omap3isp/ispccp2.c
> > > @@ -1140,6 +1140,11 @@ int omap3isp_ccp2_init(struct isp_device *isp)
> > > if (isp->revision == ISP_REVISION_2_0) {
> > > ccp2->vdds_csib = devm_regulator_get(isp->dev, "vdds_csib");
> > > if (IS_ERR(ccp2->vdds_csib)) {
> > > + if (PTR_ERR(ccp2->vdds_csib) == -EPROBE_DEFER) {
> > > + dev_dbg(isp->dev,
> > > + "Can't get regulator vdds_csib,
> > deferring probing\n");
> > > + return -EPROBE_DEFER;
> > > + }
> > > dev_dbg(isp->dev,
> > > "Could not get regulator vdds_csib\n");
> >
> > I would just move this message above the -EPROBE_DEFER check and remove the
> > one inside the check. Probe deferral debug information can be obtained by
> > enabling the debug messages in the driver core.
>
> Actually, in such case perhaps the message in -EPROBE_DEFER could be
> removed. Deferred probing happens all the time. OTOH "Could not get
> regulator" probably should be dev_err(), as it will make device
> unusable?
Isn't this only if you need ccp2?
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
