From: Jasmin Jessich <jasmin@xxxxxx> Changes V2 to V3: Fixed the remarks from Antti Polosaari. Checked the code with checkpatch.pl -strict and fixed all the findings. These patch series is the V3 version adapted to the already merged patches from V1 and other merged patches. It does no longer rename constants (see V1 of this series), as stated by Mauro as a no-go. It still fixed nearly all the style issues reported by checkpatch.pl in dvb-core/dvb_ca_en50221.c. In addtion also the checks have been fixed. I also renamed the patch title, because "Make checkpatch happy ?" is a bad title and checkpatch complained about it. I also refactored the state machine a bit more and added the new function dvb_ca_en50221_poll_cam_gone in a new patch. Two of the remaining warnings are "WARNING: memory barrier without comment". I have really no clue why there is a call to "mb()" in that file, so I can't fill in a good comment. I kept some of the "WARNING: line over 80 characters" findings, which are strings for debugging, which shouldn't be split in several lines (will give other warning). And some lines, where a change would decrease the readability. There it would be better to split the functions in new subroutines, which I currently didn't. And finally one "WARNING: Prefer [subsystem eg: netdev]_dbg", complaining about the "dprintk" macro. In my opinion it is correctly used and it is normally disabled anyway. The main problem of the original code was the size of the lines and the structural complexity of some functions. Beside refactoring of the thread state machine, I used in nearly every function a helper pointer "sl" (for "slot" structure) instead the whole structure path. This saved also a lot of characters in long lines and made the code more readable in my opinion. I split the patch set is small pieces for easier review, compiled each step and tested the resulting driver on my hardware with the DD DuoFlex CI (single) card. I took a lot of care in the first two patches to really keep the code as is without loosing any line during refactoring. Each patch has been tested for compiling and is therefore bisect save. I also tested the complete patch set with two CAMs and did several plug- unplug cycles. And the CAM did decode the program as expected. Additional note: In the first patch there are two checks "Logical continuations should be on the previous line" which can't be fixed easily without braking the 80 col limit. Both of them will be resolved automatically with the 2nd patch "New function dvb_ca_en50221_poll_cam_gone". Jasmin Jessich (16): [media] dvb-core/dvb_ca_en50221.c: Refactored dvb_ca_en50221_thread [media] dvb-core/dvb_ca_en50221.c: New function dvb_ca_en50221_poll_cam_gone [media] dvb-core/dvb_ca_en50221.c: use usleep_range [media] dvb-core/dvb_ca_en50221.c: Fixed block comments [media] dvb-core/dvb_ca_en50221.c: Avoid assignments in ifs [media] dvb-core/dvb_ca_en50221.c: Used a helper variable [media] dvb-core/dvb_ca_en50221.c: Added line breaks [media] dvb-core/dvb_ca_en50221.c: Removed useless braces [media] dvb-core/dvb_ca_en50221.c: Removed unused symbol [media] dvb-core/dvb_ca_en50221.c: Fixed C++ comments [media] dvb-core/dvb_ca_en50221.c: Fixed 80 char limit [media] dvb-core/dvb_ca_en50221.c: Fixed typo [media] dvb-core/dvb_ca_en50221.c: Fix again wrong EXPORT_SYMBOL order [media] dvb-core/dvb_ca_en50221.c: Fixed remaining block comments [media] dvb-core/dvb_ca_en50221.c: Fixed style issues on the whole file [media] dvb-core/dvb_ca_en50221.c: Fixed multiple blank lines drivers/media/dvb-core/dvb_ca_en50221.c | 945 +++++++++++++++++--------------- 1 file changed, 512 insertions(+), 433 deletions(-) -- 2.7.4
