Hello, On Wed, Jul 12, 2017 at 03:31:02PM +0200, Arnd Bergmann wrote: > > We also have about a bazillion > > > > warning: ‘*’ in boolean context, suggest ‘&&’ instead > > > > warnings in drivers/ata/libata-core.c, all due to a single macro that > > uses a pattern that gcc-7.1.1 doesn't like. The warning looks a bit > > debatable, but I suspect the macro could easily be changed too. > > > > Tejun, would you hate just moving the "multiply by 1000" part _into_ > > that EZ() macro? Something like the attached (UNTESTED!) patch? > > Tejun applied an almost identical patch of mine a while ago, but it seems to > have gotten lost in the meantime in some rebase: Yeah, I was scratching my head remembering your patch. Sorry about that. It should have been routed through for-4.12-fixes. > https://patchwork.kernel.org/patch/9721397/ > https://patchwork.kernel.org/patch/9721399/ > > I guess I should have resubmitted the second patch with the suggested > improvement. The new one looks good to me. Thanks. -- tejun
