On Fri, Jul 14, 2017 at 2:25 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> - return capable(CAP_SYS_ADMIN) ? : -EINVAL;
> + return capable(CAP_SYS_ADMIN) ? 1 : -EINVAL;
NAK. This takes unintentionally insane code and turns it intentionally
insane. Any non-zero return is considered an error.
The right fix is almost certainly to just return -EINVAL unconditionally.
Linus
