On 26/06/17 19:12, Laurent Pinchart wrote: > The sink pointer is used to configure routing inside the VSP, and as > such must point to the next VSP entity in the pipeline. The WPF being a > pipeline terminal sink, its output route can't be configured. The > routing configuration code already handles this correctly without > referring to the sink pointer, which thus doesn't need to be set. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> > --- > drivers/media/platform/vsp1/vsp1_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c > index 6b35e043b554..35087d5573ce 100644 > --- a/drivers/media/platform/vsp1/vsp1_drv.c > +++ b/drivers/media/platform/vsp1/vsp1_drv.c > @@ -412,7 +412,6 @@ static int vsp1_create_entities(struct vsp1_device *vsp1) > } > > list_add_tail(&video->list, &vsp1->videos); > - wpf->entity.sink = &video->video.entity; > } > } > >