On 07/03/2017 11:16 AM, Hugues Fruchet wrote: > Switch i2c device id to lower case as it is s/i2c/I2C ? > done for other omnivision cameras. s/omnivision/Omnivision This is required for properly matching driver with device on DT platforms, right? It might be worth to mention that so it is clear why we break any non-dt platform that could be already using this driver. There seem to be none in the mainline kernel tree though. > Signed-off-by: Hugues Fruchet <hugues.fruchet@xxxxxx> Reviewed-by: Sylwester Nawrocki <snawrocki@xxxxxxxxxx> > Signed-off-by: Hugues Fruchet <hugues.fruchet@xxxxxx> > --- > drivers/media/i2c/ov9650.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov9650.c b/drivers/media/i2c/ov9650.c > index 2de2fbb..1e4e99e 100644 > --- a/drivers/media/i2c/ov9650.c > +++ b/drivers/media/i2c/ov9650.c > @@ -1545,8 +1545,8 @@ static int ov965x_remove(struct i2c_client *client) > } > > static const struct i2c_device_id ov965x_id[] = { > - { "OV9650", 0 }, > - { "OV9652", 0 }, > + { "ov9650", 0 }, > + { "ov9652", 0 }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(i2c, ov965x_id);