Am Mon, 10 Jul 2017 10:41:03 +0200 schrieb Ralph Metzler <rjkm@xxxxxxxxxxxxxx>: > Daniel Scheller writes: > > From: Daniel Scheller <d.scheller@xxxxxxx> > > > > This adds the frontend driver for the MaxLinear MxL5xx family of > > tuner- demodulators, as used on Digital Devices MaxS4/8 > > four/eight-tuner cards. > > > > The driver was picked from the dddvb vendor driver package and - > > judging solely from the diff - has undergone a 100% rework: > > > > - Silly #define's used to pass multiple values to functions were > > expanded. This resulted in macro/register names not being usable > > anymore for such occurences, but makes the code WAY more read-, > > understand- and maintainable. > > OK, but why did you also replace all kinds of register value defines > with numerical values? This makes the driver much less comprehensible. I actually tried to put named identifiers back in as I don't feel very comfortable with just plain hex numbers, there aren't even that many registers that get accessed. But as I tried to do (based on the original _regs.h), I quickly found out that one register can belong to many identifiers, with the only difference being the bitshift and bitcount, so without knowing the correct names this ends up in lottery style, which isn't good either. If you have some documentation on this and can provide that, we can put names back in place of course. Best regards, Daniel Scheller -- https://github.com/herrnst
