Re: [PATCH RFC 1/2] app: kaffeine: Fix missing PCR on live streams.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 09/07/17 12:14, Mauro Carvalho Chehab wrote:
Hi Malcolm,

Em Sun,  9 Jul 2017 10:43:50 +0100
Malcolm Priestley <tvboxspy@xxxxxxxxx> escreveu:

The ISO/IEC standard 13818-1 or ITU-T Rec. H.222.0 standard allow transport
vendors to place PCR (Program Clock Reference) on a different PID.

If the PCR is unset the value is 0x1fff, most vendors appear to set it the
same as video pid in which case it need not be set.

The PCR PID is at an offset of 8 in pmtSection structure.

Thanks for the patches!

Patches look good, except for two things:

- we use camelCase at Kaffeine. So, the new field should be pcrPid ;)
Ok, Wasn't sure


- you didn't use dvbsi.xml. The way we usually update dvbsi.h and part of
   dvbsi.cpp is to add a field at dvbsi.xml and then run:

	$ tools/update_dvbsi.sh
Oh I see.



   Kaffeine should be built with the optional BUILD_TOOLS feature, in order
   for it to build the tool that parses dvbsi.xml.

Anyway, I applied your patchset and added a few pathes afterwards
adjusting it.

Thanks

How do you turn off debug the spam from epg is horrendous.

Regards


Malcolm





[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux