When CONFIC_CEC_NOTIFIER is not set and we only include cec-notifier.h we can get build warnings like these ones: "warning: ‘struct cec_notifier’ declared inside parameter list will not be visible outside of this definition or declaration" Prevent these warnings by using forward declaration of notifier structure. Signed-off-by: Jose Abreu <joabreu@xxxxxxxxxxxx> Cc: Carlos Palminha <palminha@xxxxxxxxxxxx> Cc: Hans Verkuil <hans.verkuil@xxxxxxxxx> --- include/media/cec-notifier.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/media/cec-notifier.h b/include/media/cec-notifier.h index 298f996..84f9376 100644 --- a/include/media/cec-notifier.h +++ b/include/media/cec-notifier.h @@ -21,14 +21,14 @@ #ifndef LINUX_CEC_NOTIFIER_H #define LINUX_CEC_NOTIFIER_H -#include <linux/types.h> -#include <media/cec.h> - struct device; struct edid; struct cec_adapter; struct cec_notifier; +#include <linux/types.h> +#include <media/cec.h> + #if IS_REACHABLE(CONFIG_CEC_CORE) && IS_ENABLED(CONFIG_CEC_NOTIFIER) /** -- 1.9.1
