Hello Hans, Thank you for the review. On 07/03/2017 02:24 PM, Hans Verkuil wrote: > On 06/19/2017 04:48 PM, Todor Tomov wrote: >> These files implement the platform driver code. >> >> Signed-off-by: Todor Tomov <todor.tomov@xxxxxxxxxx> >> --- >> drivers/media/platform/qcom/camss-8x16/camss.c | 630 +++++++++++++++++++++++++ >> drivers/media/platform/qcom/camss-8x16/camss.h | 96 ++++ >> 2 files changed, 726 insertions(+) >> create mode 100644 drivers/media/platform/qcom/camss-8x16/camss.c >> create mode 100644 drivers/media/platform/qcom/camss-8x16/camss.h >> >> diff --git a/drivers/media/platform/qcom/camss-8x16/camss.c b/drivers/media/platform/qcom/camss-8x16/camss.c >> new file mode 100644 >> index 0000000..a8798d1 >> --- /dev/null >> +++ b/drivers/media/platform/qcom/camss-8x16/camss.c >> @@ -0,0 +1,630 @@ >> +/* >> + * camss.c >> + * >> + * Qualcomm MSM Camera Subsystem - Core >> + * >> + * Copyright (c) 2015, The Linux Foundation. All rights reserved. >> + * Copyright (C) 2015-2016 Linaro Ltd. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 and >> + * only version 2 as published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + */ >> +#include <linux/clk.h> >> +#include <linux/media-bus-format.h> >> +#include <linux/module.h> >> +#include <linux/platform_device.h> >> +#include <linux/of.h> >> +#include <linux/slab.h> >> + >> +#include <media/media-device.h> >> +#include <media/v4l2-async.h> >> +#include <media/v4l2-device.h> >> +#include <media/v4l2-mc.h> >> +#include <media/v4l2-of.h> > > v4l2-of.h has been replaced by v4l2-fwnode.h. You need to rebase. I'll rebase for the next version of the patchset. > > Regards, > > Hans -- Best regards, Todor Tomov
