Thanks Rob, Comments addressed, and a new version 6 to be posted soon. On 22/06/17 22:34, Rob Herring wrote: > On Wed, Jun 14, 2017 at 08:58:12PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> >> Provide support for the ADV7481 and ADV7482. >> >> The driver is modelled with 4 subdevices to allow simultaneous streaming >> from the AFE (Analog front end) and HDMI inputs though two CSI TX >> entities. >> >> The HDMI entity is linked to the TXA CSI bus, whilst the AFE is linked >> to the TXB CSI bus. >> >> The driver is based on a prototype by Koji Matsuoka in the Renesas BSP, >> and an earlier rework by Niklas Söderlund. >> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> >> --- ... >> + >> +The digital output port nodes must contain at least one endpoint. >> + >> +Ports are optional if they are not connected to anything at the hardware level, >> +but the driver may not provide any support for ports which are not described. > > What the driver does is not relevant to the binding. Of course. (Fixed) > >> + >> +Example: >> + >> + video_receiver@70 { > > video-receiver@70 Aha, I didn't realise the distinction between using '-' in node names and properties vs '_' in labels. Hopefully updated in my mind map. And I'll try to get this one right in the future. :) -- Regards Kieran