On 26/06/17 11:26, Sakari Ailus wrote: > VIDIOC_S_FMT may return EBUSY if the device is streaming or there are > buffers allocated. Document this. > > Signed-off-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx> Acked-by: Hans Verkuil <hans.verkuil@xxxxxxxxx> Can you also add this to S_STD, S_INPUT, S_OUTPUT and S_CROP? And update the EBUSY description for S_DV_TIMINGS and S_SELECTION since this new description is much better than what is currently there. Thanks, Hans > --- > Documentation/media/uapi/v4l/vidioc-g-fmt.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/vidioc-g-fmt.rst b/Documentation/media/uapi/v4l/vidioc-g-fmt.rst > index b853e48..d082f9a 100644 > --- a/Documentation/media/uapi/v4l/vidioc-g-fmt.rst > +++ b/Documentation/media/uapi/v4l/vidioc-g-fmt.rst > @@ -147,3 +147,9 @@ appropriately. The generic error codes are described at the > EINVAL > The struct :c:type:`v4l2_format` ``type`` field is > invalid or the requested buffer type not supported. > + > +EBUSY > + The device is busy and cannot change the format. This could be > + because or the device is streaming or buffers are allocated or > + queued to the driver. Relevant for :ref:`VIDIOC_S_FMT > + <VIDIOC_G_FMT>` only. >
