On Fri, 06 Nov 2009 18:05:57 +0100 Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote: > Guennadi Liakhovetski <g.liakhovetski@xxxxxx> writes: > > > Good that you mentioned this. In fact, I think, that .init should go. So > > far it is used in pcm990-baseboard.c to initialise pins. You're doing > > essentially the same - requesting and configuring GPIOs. And it has been > > agreed, that there is so far no real case, where a static > > GPIO-configuration wouldn't work. So, I would suggest you remove .init, > > configure GPIOs statically. And then submit a patch to remove .init > > completely from struct pxacamera_platform_data. Robert, do you agree? > > Yes, fully agree, I think too that GPIO should be static. > Well, the other drivers I am using (pxamci, ezx-pcap, gpio-keys, to mention some) request and configure GPIOs during their own init/probe, they don't require the *board* init code to configure them. But if you really like the static way I'll bend to your will. Regards, Antonio -- Antonio Ospite http://ao2.it PGP public key ID: 0x4553B001 A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_style Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail?
Attachment:
pgpzvO7DVfgO3.pgp
Description: PGP signature
