Hi Rob, On 01/09/2017 04:33 PM, Todor Tomov wrote: > Hi Rob, > > Happy new year, > And thank you for the review. > > On 12/01/2016 12:03 AM, Rob Herring wrote: >> On Fri, Nov 25, 2016 at 04:56:53PM +0200, Todor Tomov wrote: >>> Add DT binding document for Qualcomm Camera subsystem driver. >>> >>> Signed-off-by: Todor Tomov <todor.tomov@xxxxxxxxxx> >>> --- >>> .../devicetree/bindings/media/qcom,camss.txt | 196 +++++++++++++++++++++ >>> 1 file changed, 196 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/media/qcom,camss.txt >>> >>> diff --git a/Documentation/devicetree/bindings/media/qcom,camss.txt b/Documentation/devicetree/bindings/media/qcom,camss.txt >>> new file mode 100644 >>> index 0000000..76ad89a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/media/qcom,camss.txt >>> @@ -0,0 +1,196 @@ >>> +Qualcomm Camera Subsystem >>> + >>> +* Properties >>> + >>> +- compatible: >>> + Usage: required >>> + Value type: <stringlist> >>> + Definition: Should contain: >>> + - "qcom,8x16-camss" >> >> Don't use wildcards in compatible strings. One string per SoC. > > Ok, I'll fix this. > >> >>> +- reg: >>> + Usage: required >>> + Value type: <prop-encoded-array> >>> + Definition: Register ranges as listed in the reg-names property. >>> +- reg-names: >>> + Usage: required >>> + Value type: <stringlist> >>> + Definition: Should contain the following entries: >>> + - "csiphy0" >>> + - "csiphy0_clk_mux" >>> + - "csiphy1" >>> + - "csiphy1_clk_mux" >>> + - "csid0" >>> + - "csid1" >>> + - "ispif" >>> + - "csi_clk_mux" >>> + - "vfe0" >> >> Kind of looks like the phy's should be separate nodes since each phy has >> its own register range, irq, clocks, etc. > > Yes, there are a lot of hardware resources here. > I have decided to keep everything into a single platform device as this > represents it better from system point of view. > Following this patch, - following the short discussion which we had on Linaro Connect, - following some evaluation of the possibilities, I'd like to try to keep it as a single node. Some of the resources are separate and so appear to be the clocks too but actually there are dependencies across the hardware modules for clocks of their adjacent modules. In addition there are configuration dependencies across the hardware modules - e.g. on a CSID module a CSIPHY module's id needs to be set (and vice-versa), on a CSID module the csi lane positions need to be set and so on. So I think a single driver to handle this (and thus a single dt node) makes more sense. I'm preparing a v2 of the patch set and will send it shortly. -- Best regards, Todor Tomov
