Hi Helen, On 06/13/2017 09:35 PM, Helen Koike wrote:
This patch series improves the current video processing units in vimc (by adding more controls to the sensor and capture node, allowing the user to configure different frame formats) and also adds a debayer and a scaler node. The debayer transforms the bayer format image received in its sink pad to a bayer format by averaging the pixels within a mean window. The scaler only scales up the image for now. This patch series is based on media/master and it is available at: https://github.com/helen-fornazier/opw-staging/tree/z/sent/vimc/vpu/v4 In this version I removed the commit [media] vimc: Optimize frame generation through the pipe There was a bug when multiple links going to the same sink was enabled, I'll rework on it and re-send it in a different patch series
I ran the v4 patch series through my sparse/smatch test and found a few warnings: sparse: drivers/media/platform/vimc/vimc-debayer.c:376:30: warning: symbol 'vimc_deb_video_ops' was not declared. Should it be static? drivers/media/platform/vimc/vimc-scaler.c:270:30: warning: symbol 'vimc_sca_video_ops' was not declared. Should it be static? drivers/media/platform/vimc/vimc-sensor.c:285:30: warning: symbol 'vimc_sen_video_ops' was not declared. Should it be static? smatch: drivers/media/platform/vimc/vimc-core.c:271 vimc_add_subdevs() warn: always true condition '(--i >= 0) => (0-u32max >= 0)' drivers/media/platform/vimc/vimc-core.c:271 vimc_add_subdevs() warn: always true condition '(--i >= 0) => (0-u32max >= 0)' Can you take a look? Regards, Hans
