On Sat, Jun 17, 2017 at 01:54:51AM +0300, Andy Shevchenko wrote:
> On Thu, Jun 15, 2017 at 1:19 AM, Yong Zhi <yong.zhi@xxxxxxxxx> wrote:
>
> Commit message.
>
> > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx>
>
> > +static void writes(void *mem, ssize_t len, void __iomem *reg)
> > +{
> > + while (len >= 4) {
> > + writel(*(u32 *)mem, reg);
> > + mem += 4;
> > + reg += 4;
> > + len -= 4;
> > + }
> > +}
>
> Again, I just looked into patches and first what I see is reinventing the wheel.
>
> memcpy_toio()
Hi Andy,
That doesn't quite work: the hardware only supports 32-bit access.
So the answer is writesl().
--
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
