On Fri, Jun 16, 2017 at 07:56:41PM +0200, Janusz Krzysztofik wrote: > On Friday 16 June 2017 12:16:21 Sakari Ailus wrote: > > Hi Janusz, > > > > Thanks for the patch. A few comments below. > > > > On Fri, Jun 16, 2017 at 12:52:43AM +0200, Janusz Krzysztofik wrote: > > > Remove the soc_camera dependencies. > > > > > > Lost features, fortunately not used or not critical on test platform: > > > - soc_camera power on/off callback - replaced with clock enable/disable > > > only, no support for platform provided regulators nor power callback, > ... > > > - return soc_camera_set_power(&client->dev, ssdd, priv->clk, on); > > > + if (on) > > > + ret = v4l2_clk_enable(priv->clk); > > > + else > > > + v4l2_clk_disable(priv->clk); > > > > It'd be nicer to use the clock framework. Although I'm certainly fine with > > v4l2_clk for now, one thing at a time... > > I have that in my queue, but the test platform I'm using does not support CCF > yet so there is no easy way for the host camera interface driver to provide a > compatible clock other than v4l2_clk based. Ack. Could you send v2, addressing Hans's comment on moving this out of soc_camera directory? -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
