>> On Thu, Nov 5, 2009 at 6:45 PM, Robert Lowery <rglowery@xxxxxxxxxxxxxx>
>> wrote:
>>> Do you mean something like this (untested) patch? I'll try it out
>>> tonight.
>>>
>>> diff -r 43878f8dbfb0 linux/drivers/media/dvb/dvb-usb/cxusb.c
>>> --- a/linux/drivers/media/dvb/dvb-usb/cxusb.c Sun Nov 01 07:17:46
>>> 2009
>>> -0200
>>> +++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c Fri Nov 06 10:39:38
>>> 2009
>>> +1100
>>> @@ -666,6 +666,14 @@
>>> .parallel_ts = 1,
>>> };
>>>
>>> +static struct zl10353_config cxusb_zl10353_xc3028_config_no_i2c_gate =
>>> {
>>> + .demod_address = 0x0f,
>>> + .if2 = 45600,
>>> + .no_tuner = 1,
>>> + .parallel_ts = 1,
>>> + .disable_i2c_gate_ctrl = 1,
>>> +};
>>> +
>>> static struct mt352_config cxusb_mt352_xc3028_config = {
>>> .demod_address = 0x0f,
>>> .if2 = 4560,
>>> @@ -897,7 +905,7 @@
>>> cxusb_bluebird_gpio_pulse(adap->dev, 0x02, 1);
>>>
>>> if ((adap->fe = dvb_attach(zl10353_attach,
>>> - &cxusb_zl10353_xc3028_config,
>>> +
>>> &cxusb_zl10353_xc3028_config_no_i2c_gate,
>>> &adap->dev->i2c_adap)) == NULL)
>>> return -EIO;
>>
>> Wow, that looks shockingly similar to the patch I did for an em28xx
>> boards a couple of months ago, even down to the part where you added
>> "_no_i2c_gate" to the end! :-)
>
> I might have got some inspiration from somewhere :)
>
>>
>> Yeah, that's the fix, although from the diff I can't tell if you're
>> doing it for all zl10353 boards in cxusb.c or just yours. I would
>> have to see the source to know for sure.
>
> I only changed cxusb_dualdig4_frontend_attach() so it should be just my
> board. The only other board that was using cxusb_zl10353_xc3028_config
> was cxusb_nano2_frontend_attach(), but I left that as is since I don't
> know if that board is similarily affected.
>
> I'll try it out tonight and confirm it fixes the problem
Devin,
I have confirmed the patch below fixes my issue. Could you please merge
it for me?
Thanks
-Rob
Fix hang on DViCO FusionHDTV DVB-T Dual Digital 4 (rev 1)
Signed Off: Robert Lowery <rglowery@xxxxxxxxxxxxxx>
diff -r c57f47cfb0e8 linux/drivers/media/dvb/dvb-usb/cxusb.c
--- a/linux/drivers/media/dvb/dvb-usb/cxusb.c Wed Nov 04 18:21:15 2009
-0200
+++ b/linux/drivers/media/dvb/dvb-usb/cxusb.c Fri Nov 06 13:28:07 2009
+1100
@@ -666,6 +666,14 @@
.parallel_ts = 1,
};
+static struct zl10353_config cxusb_zl10353_xc3028_config_no_i2c_gate = {
+ .demod_address = 0x0f,
+ .if2 = 45600,
+ .no_tuner = 1,
+ .parallel_ts = 1,
+ .disable_i2c_gate_ctrl = 1,
+};
+
static struct mt352_config cxusb_mt352_xc3028_config = {
.demod_address = 0x0f,
.if2 = 4560,
@@ -897,7 +905,7 @@
cxusb_bluebird_gpio_pulse(adap->dev, 0x02, 1);
if ((adap->fe = dvb_attach(zl10353_attach,
- &cxusb_zl10353_xc3028_config,
+ &cxusb_zl10353_xc3028_config_no_i2c_gate,
&adap->dev->i2c_adap)) == NULL)
return -EIO;
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
