Hi Dave,
Am 15.06.2017 um 15:38 schrieb Dave Stevenson:
> Hi Hans.
>
> "On 15 June 2017 at 08:12, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
>> Hi Dave,
>>
>> Here is a quick review of this driver. Once a v2 is posted I'll do a more
>> thorough
>> check.
> Thank you. I wasn't expecting such a quick response.
>
>> On 06/14/2017 05:15 PM, Dave Stevenson wrote:
>>> ...
>>>
>>> +
>>> +struct bayer_fmt {
>>> + u32 fourcc;
>>> + u8 depth;
>>> +};
>>> +
>>> +const struct bayer_fmt all_bayer_bggr[] = {
>>> + {V4L2_PIX_FMT_SBGGR8, 8},
>>> + {V4L2_PIX_FMT_SBGGR10P, 10},
>>> + {V4L2_PIX_FMT_SBGGR12, 12},
>>> + {V4L2_PIX_FMT_SBGGR16, 16},
>>> + {0, 0}
>>> +};
>>> +
>>> +const struct bayer_fmt all_bayer_rggb[] = {
>>> + {V4L2_PIX_FMT_SRGGB8, 8},
>>> + {V4L2_PIX_FMT_SRGGB10P, 10},
>>> + {V4L2_PIX_FMT_SRGGB12, 12},
>>> + /* V4L2_PIX_FMT_SRGGB16, 16},*/
>>
>> Why is this commented out? Either uncomment, add a proper comment explaining
>> why
>> or remove it.
> I was developing this against the Pi specific tree, and that is still
> on 4.9 which didn't have several of the 16 bit Bayer formats. I see
> that Sakari has added them (thank you Sakari), so I can uncomment
> them.
does this series work with Linux Mainline (incl. bcm283x dts files)?
In case not, please tell what is missing?
Regards
Stefan
