Am 15.06.2017 um 09:12 schrieb Hans Verkuil: > Hi Dave, > > Here is a quick review of this driver. Once a v2 is posted I'll do a > more thorough > check. > > On 06/14/2017 05:15 PM, Dave Stevenson wrote: >> Add driver for the Unicam camera receiver block on >> BCM283x processors. >> >> Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx> >> --- >> drivers/media/platform/Kconfig | 1 + >> drivers/media/platform/Makefile | 2 + >> drivers/media/platform/bcm2835/Kconfig | 14 + >> drivers/media/platform/bcm2835/Makefile | 3 + >> drivers/media/platform/bcm2835/bcm2835-unicam.c | 2100 >> ++++++++++++++++++++++ >> drivers/media/platform/bcm2835/vc4-regs-unicam.h | 257 +++ >> 6 files changed, 2377 insertions(+) >> create mode 100644 drivers/media/platform/bcm2835/Kconfig >> create mode 100644 drivers/media/platform/bcm2835/Makefile >> create mode 100644 drivers/media/platform/bcm2835/bcm2835-unicam.c >> create mode 100644 drivers/media/platform/bcm2835/vc4-regs-unicam.h >> >> diff --git a/drivers/media/platform/Kconfig >> b/drivers/media/platform/Kconfig >> index 8da521a..1111aa9 100644 >> --- a/drivers/media/platform/Kconfig >> +++ b/drivers/media/platform/Kconfig >> @@ -135,6 +135,7 @@ source "drivers/media/platform/am437x/Kconfig" >> source "drivers/media/platform/xilinx/Kconfig" >> source "drivers/media/platform/rcar-vin/Kconfig" >> source "drivers/media/platform/atmel/Kconfig" >> +source "drivers/media/platform/bcm2835/Kconfig" >> config VIDEO_TI_CAL >> tristate "TI CAL (Camera Adaptation Layer) driver" >> diff --git a/drivers/media/platform/Makefile >> b/drivers/media/platform/Makefile >> index 6bbdf94..9c5e412 100644 >> --- a/drivers/media/platform/Makefile >> +++ b/drivers/media/platform/Makefile >> @@ -81,3 +81,5 @@ obj-$(CONFIG_VIDEO_MEDIATEK_VCODEC) += mtk-vcodec/ >> obj-$(CONFIG_VIDEO_MEDIATEK_MDP) += mtk-mdp/ >> obj-$(CONFIG_VIDEO_MEDIATEK_JPEG) += mtk-jpeg/ >> + >> +obj-y += bcm2835/ >> diff --git a/drivers/media/platform/bcm2835/Kconfig >> b/drivers/media/platform/bcm2835/Kconfig >> new file mode 100644 >> index 0000000..9f9be9e >> --- /dev/null >> +++ b/drivers/media/platform/bcm2835/Kconfig >> @@ -0,0 +1,14 @@ >> +# Broadcom VideoCore4 V4L2 camera support >> + >> +config VIDEO_BCM2835_UNICAM >> + tristate "Broadcom BCM2835 Unicam video capture driver" >> + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API >> + depends on ARCH_BCM2708 || ARCH_BCM2709 || ARCH_BCM2835 || >> COMPILE_TEST > ARCH_BCM2708 and ARCH_BCM2709 isn't available upstream and should be dropped.