On Wed, Jun 14, 2017 at 11:32 AM, Zhi, Yong <yong.zhi@xxxxxxxxx> wrote: > Hi, Tomasz, > > Thanks for your code review, still need more time to study and test the solution for the rest of comments, going forward, I will respond to your review first before submitting new version. Just to clarify, my note was not about addressing all the comments instantly, but rather about not leaving any unaddressed comments in newer patch sets (unless agreed with the reviewers to do that). The default assumption is that next patch set has all comments from previous one addressed. If that's not true, it's going to confuse the reviewers and make them put additional effort into comparing the code manually. I'd say it's just better to reply on the list that you need a bit more time to address the comments, rather than sending a half-done next patch set. That's just my opinion, though. Best regards, Tomasz > > Thanks, > > Yong > >> -----Original Message----- >> From: linux-media-owner@xxxxxxxxxxxxxxx [mailto:linux-media- >> owner@xxxxxxxxxxxxxxx] On Behalf Of Tomasz Figa >> Sent: Tuesday, June 13, 2017 5:01 PM >> To: Zhi, Yong <yong.zhi@xxxxxxxxx> >> Cc: linux-media@xxxxxxxxxxxxxxx; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; >> Zheng, Jian Xu <jian.xu.zheng@xxxxxxxxx>; Mani, Rajmohan >> <rajmohan.mani@xxxxxxxxx>; Toivonen, Tuukka >> <tuukka.toivonen@xxxxxxxxx>; Yang, Hyungwoo >> <hyungwoo.yang@xxxxxxxxx>; Mohandass, Divagar >> <divagar.mohandass@xxxxxxxxx> >> Subject: Re: [PATCH 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver >> >> Hi Yong, >> >> On Wed, Jun 14, 2017 at 5:17 AM, Yong Zhi <yong.zhi@xxxxxxxxx> wrote: >> > This patch adds CIO2 CSI-2 device driver for Intel's IPU3 camera >> > sub-system support. >> > >> > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx> >> > --- >> > drivers/media/pci/Kconfig | 2 + >> > drivers/media/pci/Makefile | 3 +- >> > drivers/media/pci/intel/Makefile | 5 + >> > drivers/media/pci/intel/ipu3/Kconfig | 17 + >> > drivers/media/pci/intel/ipu3/Makefile | 1 + >> > drivers/media/pci/intel/ipu3/ipu3-cio2.c | 1779 >> > ++++++++++++++++++++++++++++++ >> > drivers/media/pci/intel/ipu3/ipu3-cio2.h | 434 ++++++++ >> > 7 files changed, 2240 insertions(+), 1 deletion(-) create mode >> > 100644 drivers/media/pci/intel/Makefile create mode 100644 >> > drivers/media/pci/intel/ipu3/Kconfig >> > create mode 100644 drivers/media/pci/intel/ipu3/Makefile >> > create mode 100644 drivers/media/pci/intel/ipu3/ipu3-cio2.c >> > create mode 100644 drivers/media/pci/intel/ipu3/ipu3-cio2.h >> > >> >> I quickly checked the code and it doesn't seem to have most of my comments >> from v2 addressed. It's not a very good practice to send new version without >> addressing or at least replying to all the comments - it's the best way to lose >> track of necessary changes. Please make sure that all the comments are >> taken care of. >> >> Best regards, >> Tomasz
