Hi Arnd, On 9 June 2017 at 16:06, Arnd Bergmann <arnd@xxxxxxxx> wrote: >> Thank you for pointing out that. I'll check the >> concurrency part. By the way why do we need mutex_destoy? >> To debug an aberrate condition? > > At first I suspected the down() here was added for the same > purpose as a mutex_destroy: to ensure that we are in a sane > state before we free the device structure, but the way they > achieve that is completely different. > > However, if there is any way that a command may still be in > progress by the time we get to ngene_stop(), we may also > be lacking reference counting on the ngene structure here. > So far I haven't found any of those, and think the mutex_destroy() > is sufficient here as a debugging help. I've made the necessary changes. Thank you for reviewing all the patches. Regards, Binoy
