Hi Sakari, Mauro, On 08/06/17 21:10, Mauro Carvalho Chehab wrote: > Em Thu, 8 Jun 2017 22:32:10 +0300 > Sakari Ailus <sakari.ailus@xxxxxx> escreveu: > >> Hi Mauro, >> >> On Thu, Jun 08, 2017 at 03:00:22PM -0300, Mauro Carvalho Chehab wrote: >>> Em Wed, 7 Jun 2017 10:52:07 +0100 >>> Kieran Bingham <kbingham@xxxxxxxxxx> escreveu: >>> >>>> From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >>>> >>>> Return NULL, if a null entity is parsed for it's v4l2_subdev >>>> >>>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >>> >>> Could you please improve this patch description? >>> >>> I'm unsure if this is a bug fix, or some sort of feature... >>> >>> On what situations would a null entity be passed to this function? Sorry for not being clear enough there ... >> >> I actually proposed this patch. This change is simply for convenience --- >> the caller doesn't need to make sure the subdev is non-NULL, possibly >> obtained from e.g. media_entity_remote_pad() which returns NULL all links to >> the pad are disabled. This is a recurring pattern, and making this change >> avoids an additional check. >> >> Having something along these lines in the patch description wouldn't hurt. Yes, the above looks good ... > Patch added, with a description based on the above. And thank you :) Regards -- Kieran
