Hi Kevin, Thanks for the patch. On Fri, Jun 9, 2017 at 2:01 AM, Kevin Hilman <khilman@xxxxxxxxxxxx> wrote: > On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote: >> On 07/06/17 01:37, Kevin Hilman wrote: >>> Enable getting of subdevs from DT ports and endpoints. >>> >>> The _get_pdata() function was larely inspired by (i.e. stolen from) >>> am437x-vpfe.c >>> >>> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxx> >>> --- >>> drivers/media/platform/davinci/vpif_capture.c | 126 +++++++++++++++++++++++++- >>> drivers/media/platform/davinci/vpif_display.c | 5 + Can you make this as a separate patch. >>> include/media/davinci/vpif_types.h | 9 +- >>> 3 files changed, 134 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/media/platform/davinci/vpif_capture.c b/drivers/media/platform/davinci/vpif_capture.c >>> index fc5c7622660c..b9d927d1e5a8 100644 >>> --- a/drivers/media/platform/davinci/vpif_capture.c >>> +++ b/drivers/media/platform/davinci/vpif_capture.c >>> @@ -22,6 +22,8 @@ >>> #include <linux/slab.h> >>> >>> #include <media/v4l2-ioctl.h> >>> +#include <media/v4l2-of.h> >> >> v4l2-of.h no longer exists, so this v2 is wrong. Unfortunately this patch has >> already been merged in our master. I'm not sure how this could have slipped past >> both my and Mauro's patch testing (and yours, for that matter). > > I have that file in the various trees I tested agains. > >> Can you fix this and post a patch on top of the media master that makes this >> compile again? > > Sorry for the dumb question, but what tree are you referring to? I > tried the master branch of both [1] and [2] and both seem to have that > include. > > Kevin > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git > [2] git://linuxtv.org/mchehab/media-next.git media master is https://git.linuxtv.org/media_tree.git/ Cheers, --Prabhakar Lad
