On Thu, Jun 8, 2017 at 12:04 PM, Binoy Jayan <binoy.jayan@xxxxxxxxxx> wrote: > The semaphore 'stream_mutex' is used as a simple mutex, so > it should be written as one. Semaphores are going away in the future. > > Signed-off-by: Binoy Jayan <binoy.jayan@xxxxxxxxxx> > --- Looks correct, though I wonder whether it would be nicer to move the mutex_lock/unlock() to the caller to avoid repeating the unlock() five times. Either way, Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>