Re: [PATCH 0/7] Add block read/write to en50221 CAM functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Em Thu, 8 Jun 2017 09:31:25 +0200
"Jasmin J." <jasmin@xxxxxx> escreveu:

> Hello Mauro!
> 
>  > It should be, instead:
>  > 	From: Ralph Metzler <km@xxxxxxxxxxxxxx>  
> I thought it is enough to write him in the Signed-off-by as first.

No, it isn't. It is possible to have a patch authored by someone that
didn't sign. We don't usually accept it at the Kernel (on exceptional
cases, we might end accepting patches without SOB), but other projects
that use git may not require SOB.

> This From line is automatically generated by Git with Format Patch
> and then used by send. 

Git should take it from the author's name at your git tree. You
can change it with git filter-branch. Something like:

git filter-branch -f --commit-filter '
        if [ "$GIT_COMMITTER_NAME" = "My Name" ];
        then
                GIT_AUTHOR_NAME="Other Name";
                GIT_AUTHOR_EMAIL="other@email";
                GIT_COMMITTER_EMAIL="my@email";
		GIT_AUTHOR_DATE=$GIT_COMMITTER_DATE;
                git commit-tree "$@";
        else
                git commit-tree "$@";
        fi' tag1..tag2

Btw, you can also use filter-branch to rename things at the code, e. g.:

	git filter-branch -f --tree-filter 'for i in $(git grep -l MEDIA_ENT_T_AV_BRIDGE); do sed s,MEDIA_ENT_T_AV_BRIDGE,MEDIA_ENT_T_AV_DMA,g -i $i; done ' tag2..tag3

(tag1, tag2, tag3 can actually be a changeset hash, a branch and/or a tag)

> However I should change that and my mail program
> still accepting it?
> I will try.
> 
> BR,
>     Jasmin



Thanks,
Mauro



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux