On Thu, Jun 01, 2017 at 08:19:23AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 2017-05-31 21:55, Krzysztof Kozlowski wrote:
> > On Wed, May 31, 2017 at 01:00:17PM +0200, Marek Szyprowski wrote:
> > > Exynos5250 and Exynos542x SoCs have the same CEC hardware module as
> > > Exynos4 SoC series, so enable support for it using the same compatible
> > > string.
> > >
> > > Tested on Odroid XU3 (Exynos5422) and Google Snow (Exynos5250) boards.
> > >
> > > Signed-off-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> > > ---
> > > arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 +++++++
> > > arch/arm/boot/dts/exynos5250-snow-common.dtsi | 4 ++++
> > > arch/arm/boot/dts/exynos5250.dtsi | 13 +++++++++++++
> > > arch/arm/boot/dts/exynos5420-pinctrl.dtsi | 7 +++++++
> > > arch/arm/boot/dts/exynos5420.dtsi | 13 +++++++++++++
> > > arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ++++
> > > 6 files changed, 48 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > > index 2f6ab32b5954..1fd122db18e6 100644
> > > --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi
> > > @@ -589,6 +589,13 @@
> > > samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> > > samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> > > };
> > > +
> > > + hdmi_cec: hdmi-cec {
> > > + samsung,pins = "gpx3-6";
> > > + samsung,pin-function = <EXYNOS_PIN_FUNC_3>;
> > > + samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
> > > + samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
> > > + };
> > > };
> > > &pinctrl_1 {
> > > diff --git a/arch/arm/boot/dts/exynos5250-snow-common.dtsi b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
> > > index 8f3a80430748..e1d293dbbe5d 100644
> > > --- a/arch/arm/boot/dts/exynos5250-snow-common.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250-snow-common.dtsi
> > > @@ -272,6 +272,10 @@
> > > vdd_pll-supply = <&ldo8_reg>;
> > > };
> > > +&hdmicec {
> > > + status = "okay";
> > > +};
> > > +
> > > &i2c_0 {
> > > status = "okay";
> > > samsung,i2c-sda-delay = <100>;
> > > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> > > index 79c9c885613a..fbdc1d53a2ce 100644
> > > --- a/arch/arm/boot/dts/exynos5250.dtsi
> > > +++ b/arch/arm/boot/dts/exynos5250.dtsi
> > > @@ -689,6 +689,19 @@
> > > samsung,syscon-phandle = <&pmu_system_controller>;
> > > };
> > > + hdmicec: cec@101B0000 {
> > > + compatible = "samsung,s5p-cec";
> > > + reg = <0x101B0000 0x200>;
> > > + interrupts = <GIC_SPI 114 IRQ_TYPE_LEVEL_HIGH>;
> > > + clocks = <&clock CLK_HDMI_CEC>;
> > > + clock-names = "hdmicec";
> > > + samsung,syscon-phandle = <&pmu_system_controller>;
> > > + hdmi-phandle = <&hdmi>;
> > > + pinctrl-names = "default";
> > > + pinctrl-0 = <&hdmi_cec>;
> > > + status = "disabled";
> > > + };
> > What about Exynos5410? Is it applicable there as well? If yes, then this
> > could be added to exynos5.dtsi... although then clocks and pinctrl
> > should remain in SoC-specific DTSI. We're following such pattern in many
> > places but I am not sure if this more readable.
>
> Exynos5410 has the same HW module, but as for now, it doesn't have support
> for
> HDMI due to missing a few pieces (mainly clocks definitions). I'm not sure
> if it makes sense to add only HDMICEC without HDMI itself. Maybe later, when
> multimedia support is added to Exynos5410, this can be integrated to
> exynos5.dtsi.
Sounds fair, applied. Thanks!
Best regards,
Krzysztof
