On 05/29/2017 11:07 AM, Benjamin Gaignard wrote:
2017-05-29 10:54 GMT+02:00 Hans Verkuil <hverkuil@xxxxxxxxx>:
Hi Benjamin,
On 05/29/2017 10:34 AM, Benjamin Gaignard wrote:
version 4:
- rebased on Hans cec-config branch
- rework bindings commit message
- add notifier support
I really don't like this change. This forced me to think about this a bit
more,
and I think this requires another change as well.
The problem you have is that the drm driver for this platform isn't ready
yet,
so this CEC driver needs userspace to provide a physical address since it
can't
use a notifier.
Trying to support both is a bad idea since this runs the risk that we will
forget
to remove the CAP_PHYS_ADDR path later.
I would like stm32 cec driver to be able to work with or without
notifier support.
stm32 are small platforms and not everybody will use hdmi because of memory
consomption but cec can be used anyway.
Ah, that's a good point.
So drop the notifier and add a comment where you describe that once the drm
driver becomes available notifier support will be added, but that CAP_PHYS_ADDR
remains allowed in cases where the drm driver isn't enabled due to the small
size of the platform.
With that comment it can stay in mainline.
When the drm driver arrives the notifier should probably be automatically
selected when the drm driver is enabled. I want to avoid the combination of
CAP_PHYS_ADDR and a drm driver, that shouldn't happen.
Regards,
Hans
