On Sun, May 28, 2017 at 10:23:37AM +0200, David Härdeman wrote: > On Sun, May 21, 2017 at 09:57:13AM +0100, Sean Young wrote: > >On Mon, May 01, 2017 at 06:03:51PM +0200, David Härdeman wrote: > >> If an error is generated, nonseekable_open() shouldn't be called. > > > >There is no harm in calling nonseekable_open(), so this commit is > >misleading. > > I'm not sure why you consider it misleading? If there's an error, the > logic thing to do is to error out immediately and not do any further > work? The commit message says that nonseekable_open() should not be called, suggesting there is a bug which is not the case. Sean
