I dropped the changing bayer order support. -Hyungwoo -----Original Message----- > From: Sakari Ailus [mailto:sakari.ailus@xxxxxx] > Sent: Saturday, May 27, 2017 12:53 PM > To: Yang, Hyungwoo <hyungwoo.yang@xxxxxxxxx> > Cc: linux-media@xxxxxxxxxxxxxxx; sakari.ailus@xxxxxxxxxxxxxxx; Zheng, Jian Xu <jian.xu.zheng@xxxxxxxxx> > Subject: Re: [PATCH 1/1] [media] i2c: add support for OV13858 sensor > > On Fri, May 26, 2017 at 10:53:30PM +0000, Yang, Hyungwoo wrote: > > Hi Sakari, > > > > I've submitted V2 yesterday. If possible, can you review that one also ? > > I'm learning many things from your review comments. > > > > I think in V2, I've addressed most of comments except raw bayer format. > > > > For ray bayer format, for now, I intentionally don't support crop > > since it requires more complexity to meet request from > > _set_pad_format() while keeping FOV for the resolutions with the same > > ratio(4:3 or 16:9). Yes, it is hacky but I thought it's OK unless there's a need to support crop. > > Hm..... I'm thinking drop "bayer order change" since it is not that > > meaningful. Should I ? > > If you don't need to support other bayer orders, that'd be an easy solution. > The support can always be added later on. > > > > > For VBLANK, I realized I made wrong comments just after I send it. > > Yeas, it shouldn't be read-only. So you can see that VBLANK I added in > > V2 is NOT read-only. > > Ack, I'll check that, most likely on Monday. > > -- > Sakari Ailus > e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx >
