On Thu, May 18, 2017 at 11:06:44AM -0300, Mauro Carvalho Chehab wrote: > The logic with toggles the pad_mouse is confusing. Now, gcc 7.1 > complains about it: > > drivers/media/rc/imon.c: In function 'imon_incoming_scancode': > drivers/media/rc/imon.c:1725:23: warning: '~' on a boolean expression [-Wbool-operation] > ictx->pad_mouse = (~ictx->pad_mouse) & 0x1; > ^ > drivers/media/rc/imon.c:1725:23: note: did you mean to use logical not? > ictx->pad_mouse = (~ictx->pad_mouse) & 0x1; > ^ > ! > > Rewrite it to be clearer for both code reviewers and gcc. This was already spotted by Arnd. https://patchwork.linuxtv.org/patch/41270/ Thanks Sean
