On Wed, May 17, 2017 at 09:09:57PM +0100, Sean Young wrote: >Hi David, > >On Wed, May 03, 2017 at 12:04:00PM +0200, David Härdeman wrote: >> The device core infrastructure is based on the presumption that >> once a driver calls device_add(), it must be ready to accept >> userspace interaction. >> >> This requires splitting rc_setup_rx_device() into two functions >> and reorganizing rc_register_device() so that as much work >> as possible is performed before calling device_add(). >> >> Version 2: switch the order in which rc_prepare_rx_device() and >> ir_raw_event_prepare() gets called so that dev->change_protocol() >> gets called before device_add(). > >I've looked at this patch and I don't see what problem it solves; >what user-space interaction is problematic? It's a preparatory patch, the next patch ("rc-core: cleanup rc_register_device pt2") is the one which removes the dev->initialized hack (which currently papers over the fact that device_add() is called before userspace is actually ready to accept sysfs interaction). Does that answer your question? //David