On 10/05/17 19:13, Sakari Ailus wrote: > Hi Kieran, > > Thanks for the patch. > > On Wed, May 10, 2017 at 05:45:54PM +0100, Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> >> With the fwnode implementation, of_node is no longer used. >> >> Remove it. >> >> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> --- >> include/media/v4l2-subdev.h | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h >> index 5f1669c45642..a40760174797 100644 >> --- a/include/media/v4l2-subdev.h >> +++ b/include/media/v4l2-subdev.h >> @@ -787,7 +787,6 @@ struct v4l2_subdev_platform_data { >> * is attached. >> * @devnode: subdev device node >> * @dev: pointer to the physical device, if any >> - * @of_node: The device_node of the subdev, usually the same as dev->of_node. >> * @fwnode: The fwnode_handle of the subdev, usually the same as >> * either dev->of_node->fwnode or dev->fwnode (whichever is non-NULL). >> * @async_list: Links this subdev to a global subdev_list or @notifier->done >> @@ -820,7 +819,6 @@ struct v4l2_subdev { >> void *host_priv; >> struct video_device *devnode; >> struct device *dev; >> - struct device_node *of_node; >> struct fwnode_handle *fwnode; >> struct list_head async_list; >> struct v4l2_async_subdev *asd; > > This is actually the difference my local v4l2-acpi branch and what I have in > my git.linuxtv.org tree. :-) So the change is there, embedded in the same > patch that converts the users. > > I'll upload it later tonight. Great - no problem then :) -- Cheers Kieran