Hi Sakari, On Thu, May 4, 2017 at 4:45 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote: >> --- a/drivers/media/platform/rcar-vin/rcar-dma.c >> +++ b/drivers/media/platform/rcar-vin/rcar-dma.c >> @@ -16,6 +16,7 @@ >> >> #include <linux/delay.h> >> #include <linux/interrupt.h> >> +#include <linux/pm_runtime.h> >> >> #include <media/videobuf2-dma-contig.h> >> >> @@ -1240,3 +1241,45 @@ int rvin_dma_probe(struct rvin_dev *vin, int irq) >> >> return ret; >> } >> + >> +/* ----------------------------------------------------------------------------- >> + * Gen3 CHSEL manipulation >> + */ >> + >> +int rvin_set_chsel(struct rvin_dev *vin, u8 chsel) >> +{ >> + u32 ifmd; >> + >> + pm_runtime_get_sync(vin->dev); > > Can this fail? Just wondering. In theory, yes. In practice, no, unless the system is completely broken. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds