Re: [PATCH 11/25] [media] dvb-core: use pr_foo() instead of printk()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, October 14, 2016 2:45:49 PM CEST Mauro Carvalho Chehab wrote:
> 
> -#define dprintk        if (debug) printk
> +#define dprintk(fmt, arg...) do {                                      \
> +       if (debug)                                                      \
> +               printk(KERN_DEBUG pr_fmt("%s: " fmt),                   \
> +                       __func__, ##arg);                               \
> +} while (0)
> 

Why not just use pr_debug() or dev_dbg() here? They already
have a way to control output at runtime (CONFIG_DYNAMIC_DEBUG).

	Arnd



[Index of Archives]     [Linux Input]     [Video for Linux]     [Gstreamer Embedded]     [Mplayer Users]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux