On 04/30/2017 01:34 AM, Yong Zhi wrote: > This patch adds CIO2 CSI-2 device driver for > Intel's IPU3 camera sub-system support. > > The V4L2 fwnode matching depends on the following work: > > <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=v4l2-acpi> > > Signed-off-by: Yong Zhi <yong.zhi@xxxxxxxxx> > --- > drivers/media/pci/Kconfig | 2 + > drivers/media/pci/Makefile | 3 +- > drivers/media/pci/ipu3/Kconfig | 17 + > drivers/media/pci/ipu3/Makefile | 1 + > drivers/media/pci/ipu3/ipu3-cio2.c | 1813 ++++++++++++++++++++++++++++++++++++ > drivers/media/pci/ipu3/ipu3-cio2.h | 425 +++++++++ > 6 files changed, 2260 insertions(+), 1 deletion(-) > create mode 100644 drivers/media/pci/ipu3/Kconfig > create mode 100644 drivers/media/pci/ipu3/Makefile > create mode 100644 drivers/media/pci/ipu3/ipu3-cio2.c > create mode 100644 drivers/media/pci/ipu3/ipu3-cio2.h Not a review (yet), just something I noticed: I would recommend calling the directory intel-ipu3. The ipu3 name is a bit obscure. Is it likely that there will be more Intel PCI drivers? If so, then we can consider putting it in pci/intel/ipu3/. Also, can you post as a reply to the cover letter of this patch series the output of 'v4l2-compliance' and 'v4l2-compliance -f'. Make sure you use the latest v4l2-compliance code from the master branch of the v4l-utils repository (https://git.linuxtv.org/v4l-utils.git/). Regards, Hans
