Hi Pavel,
On 03/04/17 15:03, Sakari Ailus wrote:
> Hi Pavel,
>
> On Thu, Mar 02, 2017 at 01:38:48PM +0100, Pavel Machek wrote:
>> Hi!
>>
>>>> Ok, how about this one?
>>>> omap3isp: add rest of CSI1 support
>>>>
>>>> CSI1 needs one more bit to be set up. Do just that.
>>>>
>>>> It is not as straightforward as I'd like, see the comments in the code
>>>> for explanation.
>> ...
>>>> + if (isp->phy_type == ISP_PHY_TYPE_3430) {
>>>> + struct media_pad *pad;
>>>> + struct v4l2_subdev *sensor;
>>>> + const struct isp_ccp2_cfg *buscfg;
>>>> +
>>>> + pad = media_entity_remote_pad(&ccp2->pads[CCP2_PAD_SINK]);
>>>> + sensor = media_entity_to_v4l2_subdev(pad->entity);
>>>> + /* Struct isp_bus_cfg has union inside */
>>>> + buscfg = &((struct isp_bus_cfg *)sensor->host_priv)->bus.ccp2;
>>>> +
>>>> + csiphy_routing_cfg_3430(&isp->isp_csiphy2,
>>>> + ISP_INTERFACE_CCP2B_PHY1,
>>>> + enable, !!buscfg->phy_layer,
>>>> + buscfg->strobe_clk_pol);
>>>
>>> You should do this through omap3isp_csiphy_acquire(), and not call
>>> csiphy_routing_cfg_3430() directly from here.
>>
>> Well, unfortunately omap3isp_csiphy_acquire() does have csi2
>> assumptions hard-coded :-(.
>>
>> This will probably fail.
>>
>> rval = omap3isp_csi2_reset(phy->csi2);
>> if (rval < 0)
>> goto done;
>
> Could you try to two patches I've applied on the ccp2 branch (I'll remove
> them if there are issues).
>
> That's compile tested for now only.
>
I've updated the CCP2 patches here on top of the latest fwnode patches:
<URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=ccp2>
No even compile testing this time though. I'm afraid I haven't had the
time to otherwise to work on the CCP2 support, so there are no other
changes besides the rebase.
I intend to send a pull request for the fwnode patches once we have the
next rc1 in media tree so then we can have the patches on plain media
tree master branch.
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx
