Hej Sakari, Thanks for your feedback. On 2017-05-02 23:23:47 +0300, Sakari Ailus wrote: > Hi Niklas, > > Niklas Söderlund wrote: > > For drivers registering notifiers with more then one subdevices it's > > difficult to know exactly which one is being bound in each call to the > > notifiers bound callback. Comparing OF nodes became harder after the > > introduction of fwnode where the two following comparisons are not equal > > but where so previous to fwnode. > > > > asd.match.fwnode.fwnode == of_fwnode_handle(subdev->dev->of_node) > > > > asd.match.fwnode.fwnode == of_fwnode_handle(subdev->of_node) > > > > It's also not ideal to directly access the asd.match union without first > > checking the match_type. So to make it easier for drivers to perform > > this type of matching export the v4l2 async match helpers with a new > > symbol v4l2_async_match(). This wold replace the comparisons above with: > > > > v4l2_async_match(subdev, &asd) > > Where do you need such a thing, i.e. what do you want to do? Do you have an > example of where this is helpful? > > The async framework has been designed to make it easy to store driver > specific information to an async sub-device but I'm not sure if all drivers > do this. Some do at least. You are correct, there is no need for this patch. Please disregard it, and sorry for the noise. Laurent also pointed this out to me and asked why I did not use the v4l2_async_subdev pointer provided to the notifier bound callback instead of the subdev->of_node to match. I now feel rather silly.. But with that modification my issue is solved without any v4l2 modifications and the code is more clear so I'm also happy. > > -- > Kind regards, > > Sakari Ailus > sakari.ailus@xxxxxxxxxxxxxxx -- Regards, Niklas Söderlund
