Hi! > Hmm... if the idea is to have a control that doesn't do ringing > compensation, then it should be clear at the control's descriptions > that: > > - V4L2_CID_FOCUS_ABSOLUTE should be used if the VCM has ringing > compensation; > - V4L2_CID_VOICE_COIL_CURRENT and V4L2_CID_VOICE_COIL_RING_COMPENSATION > should be used otherwise. > > Btw, if the rationale for this patch is to support devices without > ring compensation, so, both controls and their descriptions should > be added at the same time, together with a patchset that would be > using both. > > > How about adding such an explanation added to the commit message? > > It is not enough. Documentation should be clear that VCM devices > with ring compensation should use V4L2_CID_FOCUS_ABSOLUTE. Is ring compensation actually a big deal? We do not publish enough information to userland about how fast the autofocus system is, anyway, so it looks like userland can't depend on such details... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
